datastore::switch_epochとlog_channel::begin_sessionの呼出しがオーバラップする可能性についてapi コメントに追記 #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and log_channel::begin_session
この部分はOK
この部分は、
という点が気になります。次のようなコメントが良いと思うのですが、いかがでしょうか。 datastore::switch_epoch() and this function can be called simultaneously. If these functions are invoked at the same time, the result will be as if one of them was called first, but it is indeterminate which one will take precedence. |
|
なるほど、「関数呼び出し同士に前後はつくがどちらが先になるかは不定」という書き方ですね。よさそうに思います。この内容でブランチを更新しました。 |
|
問題ないと思うのでマージしました。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
会議で議論した内容 ( https://github.com/project-tsurugi/tsurugi-issues/issues/925 )に従ってlimestone API doc commentに追記したいと思います。
@umegane レビューのうえ、問題なければマージお願いします。